Conversation
Agent-Logs-Url: https://github.com/binarywang/WxJava/sessions/de3cda32-0f6e-4d2f-87cc-9fd6ae77d9e2 Co-authored-by: binarywang <1343140+binarywang@users.noreply.github.com>
Agent-Logs-Url: https://github.com/binarywang/WxJava/sessions/de3cda32-0f6e-4d2f-87cc-9fd6ae77d9e2 Co-authored-by: binarywang <1343140+binarywang@users.noreply.github.com>
🤖 Augment PR SummarySummary: This PR introduces a Maven BOM module to make it easier to align versions when users depend on multiple WxJava artifacts. Changes:
Technical Notes:
🤖 Was this summary useful? React with 👍 or 👎 |
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" | ||
| xmlns="http://maven.apache.org/POM/4.0.0"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> |
There was a problem hiding this comment.
wx-java-bom currently inherits from the root wx-java parent; when consumers import this BOM, they may also inherit the parent’s full dependencyManagement (third-party libs like slf4j-api, jackson-bom, etc.), potentially overriding application-chosen versions—was that intended for this BOM’s contract?
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| <name>WxJava - BOM</name> | ||
| <description>WxJava 依赖管理 BOM(Bill of Materials),用于统一管理 WxJava 各模块的版本</description> | ||
|
|
||
| <dependencyManagement> |
There was a problem hiding this comment.
This BOM manages individual starter/plugin artifacts, but it doesn’t appear to manage the aggregator POMs (e.g., wx-java-spring-boot-starters, wx-java-solon-plugins), so users depending on those would still need to set versions explicitly.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
There was a problem hiding this comment.
Pull request overview
该 PR 新增一个 Maven BOM 模块,用于在用户同时引入多个 WxJava 子模块时,通过 dependencyManagement 统一对齐版本,避免各模块版本不一致带来的依赖冲突。
Changes:
- 新增
wx-java-bom模块(packaging=pom),在dependencyManagement中集中声明 WxJava 相关 artifact 版本为${project.version} - 根
pom.xml注册新模块,纳入多模块构建 - README 增加 BOM 的推荐用法示例
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wx-java-bom/pom.xml | 新增 BOM,用于集中管理 WxJava 相关模块版本 |
| pom.xml | 将 wx-java-bom 纳入根聚合构建模块列表 |
| README.md | 增加 BOM 引用方式与示例,指导用户使用 |
| <!-- WxJava Spring Boot Starters --> | ||
| <dependency> | ||
| <groupId>com.github.binarywang</groupId> | ||
| <artifactId>wx-java-mp-spring-boot-starter</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.github.binarywang</groupId> | ||
| <artifactId>wx-java-mp-multi-spring-boot-starter</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30f3c7eabf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <dependency> | ||
| <groupId>com.github.binarywang</groupId> | ||
| <artifactId>wx-java-bom</artifactId> | ||
| <version>4.8.0</version> |
There was a problem hiding this comment.
Update BOM example to a version that contains this module
The README snippet pins wx-java-bom to 4.8.0, but this commit is the one that introduces the wx-java-bom artifact, so users copying this example will request a version that does not include the BOM and Maven resolution will fail. This makes the new recommended setup path unusable until the documented version is changed to a release that actually publishes com.github.binarywang:wx-java-bom.
Useful? React with 👍 / 👎.
zhujianxintian
left a comment
There was a problem hiding this comment.
建议在 README.md 文件中举例使用 bom 管理依赖的时候增加说明,(4.8.0 才新增 bom 模块),减少使用者的试错成本,其他的没有问题
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/binarywang/WxJava/sessions/149464b9-8927-4a86-9535-92bdd2c03a7b Co-authored-by: binarywang <1343140+binarywang@users.noreply.github.com>
已在 commit af9b902 中将 |
|
ai是不是理解错了,那两个模块好像并没有加入 bom 的必要 @binarywang ,还是说我理解错了 |
同时引用多个 WxJava 模块时,用户需手动对齐各模块版本。新增 BOM 模块解决此问题。
变更内容
wx-java-bom模块:packaging 为pom,dependencyManagement中声明全部 WxJava 模块版本(核心模块 9 个、Spring Boot Starters 聚合 POM + 14 个子模块、Solon Plugins 聚合 POM + 11 个子模块),统一使用${project.version}pom.xml:在<modules>末尾注册wx-java-bom使用方式